[PLUGIN-1826] Error Management HTTP Source and Sink and fix sonar issues #180
+482
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amit-CloudSufi
commented
Dec 6, 2024
•
Amit-CloudSufi
commented
- Jira : https://cdap.atlassian.net/browse/PLUGIN-1826
This comment was marked as resolved.
This comment was marked as resolved.
Amit-CloudSufi
force-pushed
the
httpPluginErrorMang
branch
from
4cad117 to
fac0c1a
Compare
Amit-CloudSufi
changed the title
Amit-CloudSufi
force-pushed
the
httpPluginErrorMang
branch
2 times, most recently
from
e612cd0 to
d273336
Compare
Amit-CloudSufi
force-pushed
the
httpPluginErrorMang
branch
from
0af6ccc to
a41b2f6
Compare
…ckage to handle error provider, fix sonar issues and added Validation error for linear retry duration
Amit-CloudSufi
force-pushed
the
httpPluginErrorMang
branch
from
4f1d5f5 to
2e321fa
Compare
itsankit-google
requested changes
Dec 18, 2024
| errorMessage, String.format("Error message: %s", errorMessage), | ||
| ErrorUtils.getActionErrorByStatusCode(httpStatusCode).getErrorType(), | ||
| true, ErrorCodeType.HTTP, String.valueOf(httpStatusCode), | ||
| "https://developer.mozilla.org/en-US/docs/Web/HTTP/Status", new IllegalStateException(errorMessage)); |
There was a problem hiding this comment.
we should use official documentations link: https://datatracker.ietf.org/doc/html/rfc7231#section-6
| String errorMessage = String.format("Fetching from url '%s' returned status code '%d' and body '%s'", | ||
| nextPageUrl, httpStatusCode, response.getBody()); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), |
There was a problem hiding this comment.
don't do redundant Error message: %s
| @@ -122,8 +130,13 @@ protected BasePage getNextPage() throws IOException { | |||
| case SUCCESS: | |||
| break; | |||
| case STOP: | |||
| throw new IllegalStateException(String.format("Fetching from url '%s' returned status code '%d' and body '%s'", | |||
| nextPageUrl, httpStatusCode, response.getBody())); | |||
| String errorMessage = String.format("Fetching from url '%s' returned status code '%d' and body '%s'", | |||
| throw new IllegalArgumentException("Invalid URL: " + configURL, e); | ||
| } catch (IOException e) { | ||
| LOG.warn("Error making {} request to URL {}.", config.getMethod(), config.getUrl()); | ||
| String errorMessage = "Unable to make request. "; |
There was a problem hiding this comment.
this is not an actional error reason
| LOG.warn("Error making {} request to URL {}.", config.getMethod(), config.getUrl()); | ||
| String errorMessage = "Unable to make request. "; | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), ErrorType.UNKNOWN, true, e); |
| if (!shouldRetry) { | ||
| messageBuffer.clear(); | ||
| retryCount = 0; | ||
| String errorMessage = String.format("Unable to execute HTTP request to %s.", url); |
| retryCount = 0; | ||
| String errorMessage = String.format("Unable to execute HTTP request to %s.", url); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), ErrorType.SYSTEM, true, e); |
| String errorMessage = String.format("Unable to execute HTTP request to %s.", url); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), ErrorType.SYSTEM, true, e); | ||
|
|
| } catch (Exception e) { | ||
| String errorMessage = String.format("Unexpected error occurred while executing HTTP request to URL: %s", url); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), ErrorType.UNKNOWN, true, e); |
| @@ -247,16 +263,16 @@ public CloseableHttpClient createHttpClient(String pageUriStr) throws IOExceptio | |||
| URI uri = URI.create(pageUriStr); | |||
| AuthScope authScope = new AuthScope(new HttpHost(uri.getHost(), uri.getPort(), uri.getScheme())); | |||
| credentialsProvider.setCredentials(authScope, | |||
| new UsernamePasswordCredentials(config.getUsername(), config.getPassword())); | |||
| new UsernamePasswordCredentials(config.getUsername(), config.getPassword())); | |||
There was a problem hiding this comment.
revert unintended changes.
Comment on lines
+274
to
+275
| new UsernamePasswordCredentials( | ||
| config.getProxyUsername(), config.getProxyPassword())); |
There was a problem hiding this comment.
revert unintended changes
| } | ||
|
|
||
|
|
| @@ -311,7 +324,7 @@ private Header getAuthorizationHeader(AccessToken accessToken) { | |||
| private List<PlaceholderBean> getPlaceholderListFromURL() { | |||
| List<PlaceholderBean> placeholderList = new ArrayList<>(); | |||
| if (!(config.getMethod().equals(REQUEST_METHOD_PUT) || config.getMethod().equals(REQUEST_METHOD_PATCH) || | |||
| config.getMethod().equals(REQUEST_METHOD_DELETE))) { | |||
| config.getMethod().equals(REQUEST_METHOD_DELETE))) { | |||
There was a problem hiding this comment.
revert unintended changes
Comment on lines
+366
to
+370
| .await().with() | ||
| .pollInterval(pollInterval) | ||
| .pollDelay(config.getWaitTimeBetweenPages(), TimeUnit.MILLISECONDS) | ||
| .timeout(config.getMaxRetryDuration(), TimeUnit.SECONDS) | ||
| .until(this::executeHTTPServiceAndCheckStatusCode); |
There was a problem hiding this comment.
revert unintended changes
| String errorMessage = "Error while executing http request for remaining input messages" + | ||
| " after the batch execution."; | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), ErrorType.UNKNOWN, true, |
There was a problem hiding this comment.
Also don't we have status code information here?
| } catch (Exception e) { | ||
| throw new RuntimeException("Error while executing http request for remaining input messages " + | ||
| "after the batch execution. " + e); | ||
| String errorMessage = "Error while executing http request for remaining input messages" + |
There was a problem hiding this comment.
can we add http request information here?
| errorMessage, String.format("Error message: %s", errorMessage), | ||
| ErrorUtils.getActionErrorByStatusCode(httpStatusCode).getErrorType(), | ||
| true, ErrorCodeType.HTTP, String.valueOf(httpStatusCode), | ||
| "https://developer.mozilla.org/en-US/docs/Web/HTTP/Status", new IllegalStateException(errorMessage)); |
There was a problem hiding this comment.
similar comment here about documentation
| String errorMessage = String.format("Fetching from url '%s' returned status code '%d' and body '%s'", | ||
| config.getUrl(), httpStatusCode, httpResponseBody); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format("Error message: %s", errorMessage), |
| case SKIP: | ||
| case SEND: | ||
| LOG.warn(String.format("Fetching from url '%s' returned status code '%d' and body '%s'", | ||
| config.getUrl(), httpStatusCode, httpResponseBody)); | ||
| config.getUrl(), httpStatusCode, httpResponseBody)); |
There was a problem hiding this comment.
revert unintended changes
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.